Re: [PPC] Boot problems after the pci-v6.18-changes
- To: Manivannan Sadhasivam <mani@kernel.org>
- Cc: Lukas Wunner <lukas@wunner.de>, Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>, Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>, Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org, mad skateman <madskateman@gmail.com>, "R.T.Dickinson" <rtd2@xtra.co.nz>, Christian Zigotzky <info@xenosoft.de>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, hypexed@yahoo.com.au, Darren Stevens <darren@stevens-zone.net>, debian-powerpc@lists.debian.org
- Subject: Re: [PPC] Boot problems after the pci-v6.18-changes
- From: Christian Zigotzky <chzigotzky@xenosoft.de>
- Date: Mon, 13 Oct 2025 06:46:13 +0200
- Message-id: <[🔎] 0BE6C5AD-8DFD-4126-9B18-C012B522B442@xenosoft.de>
- In-reply-to: <[🔎] iv63quznjowwaib5pispl47gibevmmbbhl67ow2abl6s7lziuw@23koanb5uy22>
- References: <[🔎] iv63quznjowwaib5pispl47gibevmmbbhl67ow2abl6s7lziuw@23koanb5uy22>
> On 11 October 2025 at 07:36 pm, Manivannan Sadhasivam <mani@kernel.org> wrote:
>
> Hi Lukas,
>
> Thanks for looping me in. The referenced commit forcefully enables ASPM on all
> DT platforms as we decided to bite the bullet finally.
>
> Looks like the device (0000:01:00.0) doesn't play nice with ASPM even though it
> advertises ASPM capability.
>
> Christian, could you please test the below change and see if it fixes the issue?
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 214ed060ca1b..e006b0560b39 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2525,6 +2525,15 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev *dev)
> */
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_l0s_l1);
>
> +
> +static void quirk_disable_aspm_all(struct pci_dev *dev)
> +{
> + pci_info(dev, "Disabling ASPM\n");
> + pci_disable_link_state(dev, PCIE_LINK_STATE_ALL);
> +}
> +
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x6738, quirk_disable_aspm_all);
> +
> /*
> * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain
> * Link bit cleared after starting the link retrain process to allow this
>
>
> Going forward, we should be quirking the devices if they behave erratically.
>
> - Mani
>
> --
> மணிவண்ணன் சதாசிவம்
Hello Mani,
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x6738, quirk_disable_aspm_all);
Is this only for my AMD Radeon HD6870?
My AMD Radeon HD5870 is also affected.
And I tested it with my AMD Radeon HD5870.
What would the line be for all AMD graphics cards?
Thanks,
Christian
Reply to: