[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1115385: vlc: FTBFS on powerpc architecture



Control: tags -1 +patch

Hello,

On Tue, 2025-09-16 at 16:52 +0700, Jeroen Diederen wrote:
> diff -Nru vlc-3.0.21/debian/rules vlc-3.0.21/debian/rules
> --- vlc-3.0.21/debian/rules	2025-09-15 21:50:45.000000000 +0700
> +++ vlc-3.0.21/debian/rules	2025-08-23 20:15:15.000000000 +0700
> @@ -250,10 +250,13 @@
>  removeplugins += neon
>  endif
>  
> -# PowerPC build fo e5500 with altivec disabled
> +# PowerPC specific optimizations (excluding powerpcspe)
> +ifeq (,$(filter-out powerpc,$(DEB_HOST_ARCH_CPU))$(filter powerpcspe,$(DEB_HOST_ARCH)))
> +confflags += --enable-altivec
> +else
>  confflags += --disable-altivec
>  removeplugins += altivec
> -
> +endif
>  
>  # PowerPCSPE specific optimizations
>  ifeq (,$(filter-out powerpcspe,$(DEB_HOST_ARCH)))

I suggest the following alternative patch which also enables AltiVec on ppc64el:

--- debian/rules.orig   2025-08-23 15:15:15.000000000 +0200
+++ debian/rules        2025-09-17 11:35:04.464027648 +0200
@@ -250,8 +250,9 @@
 removeplugins += neon
 endif
 
-# PowerPC specific optimizations (excluding powerpcspe)
-ifeq (,$(filter-out powerpc,$(DEB_HOST_ARCH_CPU))$(filter powerpcspe,$(DEB_HOST_ARCH)))
+# PowerPC specific optimizations
+# AltiVec is currently disabled on powerpc and ppc64
+ifeq (,$(filter-out ppc64el,$(DEB_HOST_ARCH_CPU))
 confflags += --enable-altivec
 else
 confflags += --disable-altivec

I have not tested this patch though. I will do that later.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
--- debian/rules.orig	2025-08-23 15:15:15.000000000 +0200
+++ debian/rules	2025-09-17 11:35:04.464027648 +0200
@@ -250,8 +250,9 @@
 removeplugins += neon
 endif
 
-# PowerPC specific optimizations (excluding powerpcspe)
-ifeq (,$(filter-out powerpc,$(DEB_HOST_ARCH_CPU))$(filter powerpcspe,$(DEB_HOST_ARCH)))
+# PowerPC specific optimizations
+# AltiVec is currently disabled on powerpc and ppc64
+ifeq (,$(filter-out ppc64el,$(DEB_HOST_ARCH_CPU))
 confflags += --enable-altivec
 else
 confflags += --disable-altivec

Reply to: