[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Input requested on proposed chnages for Delve compilation issues on ppc64le



On Fri, Aug 29, 2025 at 01:38:24AM +0530, tshah wrote:
> I suspect it was because there were some tests which are just for amd64 and
> it was failing due to a ppc64le arch. For that,  I have created the below
> patch.
> 
> --- delve-1.24.0.orig/pkg/proc/core/core_test.go
> +++ delve-1.24.0/pkg/proc/core/core_test.go
> @@ -249,6 +249,9 @@ func logRegisters(t *testing.T, regs pro
>  }
> 
>  func TestCore(t *testing.T) {
> +    if runtime.GOARCH != "amd64" {
> +        t.Skip("TestCore only supported on amd64")
> +    }
>      if runtime.GOOS != "linux" || runtime.GOARCH == "386" {
>          t.Skip("unsupported")
>      }
> @@ -409,6 +412,9 @@ func TestCoreFpRegisters(t *testing.T) {
>  }
> 
>  func TestCoreWithEmptyString(t *testing.T) {
> +    if runtime.GOARCH != "amd64" {
> +        t.Skip("TestCore only supported on amd64")
> +    }
>      if runtime.GOOS != "linux" || runtime.GOARCH == "386" {
>          t.Skip("unsupported")
>      }
> 
> 

Those tests in particular should word on linux/arm64 at least too.

> Further, I got one more issue in the dh_auto_install stage because of
> multiple package names within the same folder, so it throws this error.

That's deliberate, the ppc64le is an experimental port that doesn't build
except if the exp.linuxppc64le flag is passed to go build. However we've had
a passing builder in CI for a while and I don't see any important tests
being skipped for ppc64le so you could send a PR to us to remove the flag,
you have to remove the clause that says !(ppc64le && exp.linuxppc64le) from
support_sentinel_linux.go 


Reply to: