[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH, v2] ofpathname: Move definition of SYS_PATH from l2of_vs() to l2of_scsi()



Another gentle ping.

On 3/22/21 11:48 AM, John Paul Adrian Glaubitz wrote:
> Ping.
> 
> On 2/9/21 1:10 AM, John Paul Adrian Glaubitz wrote:
>> SYS_PATH, which is required to calculate the plug ID of a SCSI/SATA
>> host in l2of_scsi(), is actually never set in this function but in
>> l2of_vd() where it is not used at all. Thus, move the definition of
>> SYS_PATH from l2of_vd() to l2of_scsi() to fix the calculation of the
>> plug ID in l2of_scsi().
>>
>> Fixes: 3fb2c44e22 ("ofpathname: Add support for the plug ID of a SCSI/SATA host")
>> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>> ---
>> v2:
>> - improve phrasing in commit message
>>
>>  scripts/ofpathname | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/ofpathname b/scripts/ofpathname
>> index 2ceae25..906cee9 100755
>> --- a/scripts/ofpathname
>> +++ b/scripts/ofpathname
>> @@ -573,7 +573,6 @@ l2of_vd()
>>      goto_dir $PWD "devspec"
>>  
>>      OF_PATH=`$CAT $PWD/devspec`
>> -    SYS_PATH=$PWD
>>      if [[ -z $OF_PATH ]]; then
>>          err $ERR_NO_OFPATH
>>      fi
>> @@ -807,6 +806,7 @@ l2of_scsi()
>>  
>>      if [[ -e $PWD/devspec ]]; then
>>          OF_PATH=`$CAT $PWD/devspec`
>> +        SYS_PATH=$PWD
>>      else
>>          err $ERR_NO_OFPATH
>>      fi
>>
-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


Reply to: