[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 1/3] ofpathname: Add partition support to l2of_ide() and l2of_scsi()



On 6/24/20 1:22 AM, Tyrel Datwyler wrote:
> Ok, so on the bright side I've confirmed that IBM open firmware will boot a
> pseries machine when the partition ID is provided and points at the actual PReP
> bootstrap partition. I suspect it was just generally omitted because it was
> assumed that PReP would always be the first partition historically. I believe
> these days that if it isn't the first partition OF is smart enough to locate it
> on its own which seems to further the lack of a need to explicitly provide the
> partition ID on this platforms.

Great.

> Now the downside is that ofpathname is not able to translate a OF vscsi device
> path to a logical device if that OF path includes the partition ID.

I'm aware of that and I'm planning to send a series of follow-up patches to
address the reverse translation issues, including Mac-specific paths and
partitions.

> So, I'm still inclined to say that the changes in this patch should be limited
> to the Mac platform for the time being.

The translation code for NVME block devices (l2of_nvme and of2f_nvme) handles
partitions as well, so I think it makes sense to add that support for SCSI
devices, too, on all platforms.

I will try to send a patch series later this week to address these issues.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


Reply to: