Re: Updated installation images for Debian Ports 2019-04-09
On Wed, Apr 10, 2019 at 02:48:59PM +0200, Frank Scheiner wrote:
> On 4/10/19 08:50, John Paul Adrian Glaubitz wrote:
> > On 4/10/19 4:53 AM, Dennis Clarke wrote:
> > > /usr/lib/grub-installer/mkhfs-bootstrap.sh: Permission denied
> >
> > Frank, I suggest invoking your script with "sh -c", could you test this
> > patch?
> >
> > --- grub-installer~ 2019-04-06 00:03:33.153827119 +0300
> > +++ grub-installer 2019-04-10 09:48:57.414750733 +0300
> > @@ -249,7 +249,7 @@
> > ppc64/chrp|ppc64/chrp_rs6k|ppc64/chrp_ibm|ppc64/cell)
> > ;;
> > powerpc/powermac_newworld|ppc64/powermac_newworld)
> > - /usr/lib/grub-installer/mkhfs-bootstrap.sh || exit 1
> > + sh -c '/usr/lib/grub-installer/mkhfs-bootstrap.sh' || exit 1
> > offs=$(findfs /boot/grub)
> > [ -n "$offs" ] || error "GRUB requires that the OF partition is mounted in /boot/grub" 1>&2
> > ;;
>
> Sure - I'll test and force push that change.
>
> UPDATE:
> I tested that change with [1] in "normal" installation mode and it still
> complains with "permission denied". It works through though, when I make
> "mkhfs-bootstrap.sh" executable. I then tested with a "real" sh locally
> and it behaves the same. It works with just `sh '[...]'` and
> `mkhfs-bootstrap.sh` without execute permissions.
>
> So I now included a modified change (without ` -c`,) rebased to current
> master of the upstream branch and force pushed it to my feature branch
> on salsa.d.o. The MR is at [2].
The -c makes no sense since sh -c is for launching a shell and running a
command but since the script isn't execuatable it isn't a valid command.
sh without the -c just runs the script which is what you wanted.
--
Len Sorensen
Reply to: