[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 4/5] Create and configure the missing CHRP boot script.



On 11/06/2017 12:16 PM, Frank Scheiner wrote:
> Instead of the `ofpathname` tool (which is used in `grub-install`
> internally), the `ofpath` tool is used to get the OF path of the used
> OFFS partition, as this was the only tool that produced a usable/working
> output on the tested machines (PowerMac11,2 and 7,3). We can omit the
> creation of the CHRP script as soon as the base template for it ([1]) is
> shipped with the `grub-ieee1275-bin` package. From then on it only needs
> to be reconfigured until `grub-install` gets the correct OF path.
> 
> The case clause is placed after the package version of GRUB is
> determined, as it is "needed" (but not vital) for the CHRP script, but
> before the call to `grub-install`, as this fails if this file is not
> available at the expected location.

I assume the script part and this comment paragraph can be removed, see
below.

>  ARCH="$(archdetect)"
>  info "architecture: $ARCH"
>  
> @@ -734,6 +929,17 @@ fi
>  
>  grub_debian_version="$($chroot $ROOT dpkg-query -W -f '${Version}' $inst_package)"
>  
> +case $ARCH in
> +    powerpc/powermac_newworld|ppc64/powermac_newworld)
> +	# As long as `grub.chrp.in` is not shipped with grub-ieee1275, create it
> +	# manually and place it at the path expected by `grub-install` later.
> +	if [ ! -e "$ROOT/usr/lib/grub/powerpc-ieee1275/grub.chrp.in" ]; then
> +		nw_create_boot_script "$ROOT/usr/lib/grub/powerpc-ieee1275" "grub.chrp" "$offs_part" "$grub_debian_version" || exit 1
> +		#cp "$ROOT/usr/lib/grub/powerpc-ieee1275/grub.chrp" "$ROOT/boot/grub/BootX"
> +	fi
> +	;;
> +esac
> +

The grub-ieee1275-bin package for powerpc already ships this file. We
just need to file a bug report against the grub2 source package so the
file list [1] for powerpc is copied for ppc64.

I will file a bug report in a second.

>  db_progress STEP 1
>  db_progress INFO grub-installer/progress/step_os-probe
>  os-prober > /tmp/os-probed || true
> 

> [1]
https://anonscm.debian.org/cgit/pkg-grub/grub.git/tree/debian/grub-ieee1275-bin.install.powerpc.in

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


Reply to: