[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [linux-usb-devel] USB glitches after suspend on ppc

On Thu, 07 Apr 2005 09:02:57 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> > Interesting.  Looks like pci_enable_wake(dev, state, 0) isn't
> > actually disabling wakeup on your hardware.  (Assuming
> > CONFIG_USB_SUSPEND=n; if not, then it's odd that the system went
> > back to sleep!)  Do you think that might be related to those calls
> > manipulating the Apple ASICs being in the OHCI layer rather than up
> > nearer the generic PCI glue?  (I still think they don't belong in
> > USB code -- ohci or usbcore -- at all.  If the platform-specific
> > PCI hooks don't suffice, they need fixing.)
> There are no platform hooks in the right place for now afaik.

Nope, not in upstream, but I used the ohci patch from Paul Mackerras

> Anyway, I think Colin's controller is an OHCI/EHCI NEC chip, so not
> an Apple ASIC, it's not doing anything in those calls.


Reply to: