Re: [PATCH] Re-power USB ports on wakeup
On Tue, 2005-03-15 at 17:34 +0100, Colin Leroy wrote:
> Hi list,
>
> Most of us have problems with USB unresponsive after one out of two
> wakeups. This patch fixes it for me; it looks like the port status
> isn't automatically updated (to ~PORT_POWER) when sleeping...
>
> So this patch just unpowers the ports manually at the end of ehci_suspend.
> I don't know if it's really correct: Ben & Greg, I'd like your comments. if
> it's fine, can you push it upstream?
It's probably wrong to remove power from ports that aren't explicitely
disconnected since devices on them are supposed to be in "suspend"
state, not powered off (or they lose capability of waking up the machine
for example).
There are several issues with USB and suspend. For me, for example, it
tends to kill the machine on suspend. USB and suspend never worked
properly in 2.6 and has not made much progress despite tons of code
beeing produced by the USB folks imho, though it's also a complicated
issue. I need to dig into this one of these days and see what I can
find/fix.
Ben.
Reply to: