Re: [PATCH] Fix Alsa issues including Oopses with OSS emulation
Nice to know that work is being done on the pmac ALSA driver. :)
However, I still cannot get ALSA to work at all on this iMac's Burgundy:
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=306
The old OSS driver still works, so I know that the hardware is not at
fault; this is clearly an ALSA driver problem.
Has anybody managed to get this to work on similar hardware?
On Wed, 22 Dec 2004, Benjamin Herrenschmidt wrote:
> This patch (which will be send upstream separately by the Alsa folks) fixes
> an signed vs. unsigned char problem in Alsa which was the cause of the Oops
> people were experiencing on ppc with OSS emulation and possibly other issues.
>
> Index: linux-work/sound/core/pcm_misc.c
> ===================================================================
> --- linux-work.orig/sound/core/pcm_misc.c 2004-11-22 01:51:09.000000000 +0100
> +++ linux-work/sound/core/pcm_misc.c 2004-12-22 19:11:26.297518336 +0100
> @@ -26,10 +26,10 @@
> #define SND_PCM_FORMAT_UNKNOWN (-1)
>
> struct pcm_format_data {
> - char width; /* bit width */
> - char phys; /* physical bit width */
> - char le; /* 0 = big-endian, 1 = little-endian, -1 = others */
> - char signd; /* 0 = unsigned, 1 = signed, -1 = others */
> + signed char width; /* bit width */
> + signed char phys; /* physical bit width */
> + signed char le; /* 0 = big-endian, 1 = little-endian, -1 = others */
> + signed char signd; /* 0 = unsigned, 1 = signed, -1 = others */
> unsigned char silence[8]; /* silence data to fill */
> };
>
>
>
>
>
--
Martin-Éric Racine, ICT Consultant
http://www.iki.fi/q-funk/
Reply to: