[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Hard Drive light

On 06 Dec 2004 at 00h12, Cedric Pradalier wrote:

Hi Cedric, 

> +	return sprintf(buf, "%c\n", pmu_blink_led_activated?'1':'0'); 

why not simply sprintf(buf, "%d\n", pmu_blink_led_activated) ?

> +	pmu_blink_led_activated = newact?1:0;

pmu_blink_led_activated = (newact != 0);
is enough and more nice imho.

> +	device_create_file (&of_hd_dev->dev, &dev_attr_blinking_led);

where is dev_attr_blinking_led defined ?

  http://ayttm.sf.net/ : Chat with your friends
  via msn, aim, yahoo, and more

Reply to: