[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 2.6] Add back beep support to snd-powermac

Julien BLACHE wrote:
The attached patch adds back the beep support to sound/ppc/pmac.c, aka
snd-powermac, and adds a dependency on INPUT in sound/ppc/Kconfig.

The patch is based on the code that used to be present in that file,
and got removed in early april last year. I ported it to the input
event interface based on the code used in dmasound_awacs.c.

Patch against linux-2.6.6 vanilla. Comments welcome, please apply.

Julien, this patch works well for the most part (a couple of hunks don't apply to 2.6.7 because a bit of the code it changes was removed - a little hand patching was required). However, I discovered that when audio playback is in progress, a terminal beep attempt will cause audio playback to stop. (When playing in XMMS, pausing and unpausing makes it continue.) I moved the check for (chip->playback.running || chip->capture.running) to just after the if (beep->buf == NULL) check, and now I can play audio and an attempted terminal beep won't stall out audio playback in progress, and the beep returns normally after playback stops. Other than that, it's nice to have a working terminal beep again. Thanks for the patch.

Derrik Pates

Reply to: