Re: [PATCH] For test only: pmac_zilog fixes (cups lockup at boot):
- To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
- Cc: "debian-powerpc@lists.debian.org" <debian-powerpc@lists.debian.org>, Linux Kernel list <linux-kernel@vger.kernel.org>, Matthias Urlichs <smurf@smurf.noris.de>, Martin-Éric Racine <q-funk@pp.fishpool.fi>
- Subject: Re: [PATCH] For test only: pmac_zilog fixes (cups lockup at boot):
- From: Russell King <rmk+lkml@arm.linux.org.uk>
- Date: Fri, 5 Mar 2004 09:48:07 +0000
- Message-id: <[🔎] 20040305094807.E22156@flint.arm.linux.org.uk>
- Mail-followup-to: Benjamin Herrenschmidt <benh@kernel.crashing.org>, "debian-powerpc@lists.debian.org" <debian-powerpc@lists.debian.org>, Linux Kernel list <linux-kernel@vger.kernel.org>, Matthias Urlichs <smurf@smurf.noris.de>, Martin-Éric Racine <q-funk@pp.fishpool.fi>
- In-reply-to: <[🔎] 1078478951.5698.82.camel@gaston>; from benh@kernel.crashing.org on Fri, Mar 05, 2004 at 08:29:12PM +1100
- References: <[🔎] 1078473270.5703.57.camel@gaston> <[🔎] 20040305085838.B22156@flint.arm.linux.org.uk> <[🔎] 1078477504.5700.69.camel@gaston> <[🔎] 20040305092422.C22156@flint.arm.linux.org.uk> <[🔎] 1078478951.5698.82.camel@gaston>
On Fri, Mar 05, 2004 at 08:29:12PM +1100, Benjamin Herrenschmidt wrote:
>
> > Yes, I know - but the point is its impossible to review, and I think
> > you at least have an extra level of locking which isn't needed.
> >
> > But I wouldn't know because of the huge number of changes which make
> > it impossible to read.
>
> That semaphore locking is only used to guard open/close against the
> power management callback. It greatly simplify the deal with the shared
> irq (the irq is shared between both ports). It's not used during
> normal operations.
Err. What power management callback? Are you not using uart_suspend_port
and uart_resume_port?
These functions do all the locking for you already - using state->sem.
Like I said, I can't see the twigs for the forest due to the shear
noise caused by the up -> uap change.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
Reply to: