[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: rivafb on 12" pbook



On Mon, Feb 02, 2004 at 12:45:35PM -0800, Mark Vojkovich wrote:
>   Most of your architecture assignments are wrong.  ALL of those
> in the above snipped are NV_ARCH_10.  You should use the logic in 
> the "nv" driver.
You mean:

pNv->Architecture = (pNv->Chipset & 0x0f00) >> 4;

if(pNv->Architecture < NV_ARCH_10)
     pNv->Architecture = NV_ARCH_04;

+ we'd have to handle the RIVA128 differently. James, would you let such a patch in? 
We could kill the whole arch_rev field in riva_chip_info then.
 -- Guido

Attachment: signature.asc
Description: Digital signature


Reply to: