Re: Bug#175921: patch: patch works on i386, fails on powerpc
Hi,
Not sure if this is relevant or not. The default under PPC Linux gcc is to
have all char types be unsigned by default whereas on x86 Linux char types
default to be signed (I believe). (I belive PPC Linux is unique iin this
default among Linux platforms)
Perhaps the code has someplaces where char is explictly assumed to be
signed.
You can easily test this hypothesis by having someone on ppc Linux rebuild
the patch binary with the following gcc option added:
-fsigned-char
And then re-run thetest case and see if now passes. If so, simply changing
the declaration of char to be signed char in the code is enough.
Kevin
On February 3, 2003 01:29, Michael Fedrowitz wrote:
> On Thu, Jan 09, 2003 at 07:35:56PM +0100, Michael Fedrowitz wrote:
>
> [CCing debian-powerpc, see http://bugs.debian.org/175921 for context.
> Anyone here ever seen any ppc specific breakage in GNU patch?]
>
> Hi,
>
> > Unless this can be reproduced somehow there's probably not a lot
> > anyone can do about it. Otherwise I'd be inclined to blame hardware,
> > kernel, cosmic rays or whatever.
>
> If no one gives me a good reason, why this actually was a bug in patch,
> within a week or two, I'm going to close this.
>
> -Michael
Reply to: