Re: XView bug/PPC machines available for developers?
On Mon, Sep 25, 2000 at 07:10:16PM +0200, Michael Schmitz wrote:
> > Huh? Your mileage WILL vary. That defeats the entire point of using
> > __va_copy(). avlist1 is, I assume, a va_list; a va_list is an array
> > type, and so *avlist1 means avlist1[0], which does not dereference an
> > uninitialized pointer. This patch is wrong.
>
> avlist is _not_ a va_list. Please look up the definition of avlist in
> lib/libxview/attr/attr.h yourself. avlist is a pointer to some u32 chunk
> of data, either a pointer to a avlist attribute or value IIRC.
> As such, __va_copy just so happens to work for other archs by accident.
*sigh*
Sorry, Michael, I'm too trigger happy. You're right; I bet I
introduced this bug myself.
> > A FAQ on this sort of problem has been posted to debian-powerpc about a
> > dozen times now, and also to debian-arm, IIRC.
>
> Feel free to point out a URL (searchable Debian ML archives would be nice
> to have, sometimes).
Sorry, don't have it any more :(
Dan
/--------------------------------\ /--------------------------------\
| Daniel Jacobowitz |__| SCS Class of 2002 |
| Debian GNU/Linux Developer __ Carnegie Mellon University |
| dan@debian.org | | dmj+@andrew.cmu.edu |
\--------------------------------/ \--------------------------------/
Reply to: