[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1085020: marked as done (popularity-contest: logs are not logs and should be moved to lib)

Your message dated Thu, 27 Feb 2025 15:51:36 +0000
with message-id <E1tngAi-002WCO-T2@fasolo.debian.org>
and subject line Bug#1085020: fixed in popularity-contest 1.78
has caused the Debian Bug report #1085020,
regarding popularity-contest: logs are not logs and should be moved to lib
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1085020: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1085020
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: popularity-contest
Version: 1.76
Severity: minor

Dear Maintainer,

/var/log/popularity-contest contains informations sent and not logs.
I think it could be moved to /var/lib/popularity-contest

If it should stay in /var/log I suggest to add savelog parameters
as some people would change the -c 7 coded.
i.e. I add this line in /etc/popularity-contest.conf
SAVELOG="-c 4 -l -d -D %Y%m%d"

Here is a patch for both points if needed

diff -Naur /etc/cron.daily/popularity-contest.orig  /etc/cron.daily/popularity-contest
--- /etc/cron.daily/popularity-contest.orig	2021-11-03 16:43:39.000000000 +0100
+++ /etc/cron.daily/popularity-contest	2024-10-12 11:46:56.278668865 +0200
@@ -77,8 +77,8 @@
 fi

 POPCONVAR="/var/lib/popularity-contest"
-POPCONOLD="/var/log/popularity-contest"
-POPCONNEW="/var/log/popularity-contest.$$"
+POPCONOLD="/var/lib/popularity-contest/packages"
+POPCONNEW="/var/lib/popularity-contest/packages.$$"
 POPCON="$POPCONNEW"

 last_sub()
@@ -115,9 +115,11 @@
 fi

 # keep old logs
-cd /var/log
-umask 022
-savelog -c 7 popularity-contest >/dev/null
+if [ "x$SAVELOG" != "x" ]; then
+	cd /var/lib/popularity-contest
+	umask 022
+	savelog $SAVELOG packages >/dev/null
+fi

 do_sendmail()
 {


-- System Information:
Debian Release: 12.7
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.10.11-turing (SMP w/24 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages popularity-contest depends on:
ii  debconf [debconf-2.0]  1.5.82
ii  dpkg                   1.21.22

Versions of packages popularity-contest recommends:
ii  cron [cron-daemon]              3.0pl1-162
ii  gpg                             2.2.40-1.1
ii  postfix [mail-transport-agent]  3.7.11-0+deb12u1

Versions of packages popularity-contest suggests:
ii  anacron   2.3-36
pn  tor       <none>
pn  torsocks  <none>

-- Configuration Files:
/etc/cron.daily/popularity-contest changed [not included]

-- debconf information excluded

--- End Message ---
--- Begin Message --- 
Source: popularity-contest
Source-Version: 1.78
Done: Bill Allombert <ballombe@debian.org>

We believe that the bug you reported is fixed in the latest version of
popularity-contest, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1085020@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bill Allombert <ballombe@debian.org> (supplier of updated popularity-contest package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 27 Feb 2025 15:50:46 +0100
Source: popularity-contest
Architecture: source
Version: 1.78
Distribution: unstable
Urgency: medium
Maintainer: Popularity Contest Developers <debian-popcon@lists.debian.org>
Changed-By: Bill Allombert <ballombe@debian.org>
Closes: 1085020 1098939
Changes:
 popularity-contest (1.78) unstable; urgency=medium
 .
   * README: update to note that linuxcounter is dead.
   * debian-popcon.gpg: use new submission key.
   * debian/control:
     - Updated Standards-Version from 4.6.1 to 4.7.1.  No change needed.
     - Set Rules-Requires-Root: no
   * debian/cron.daily:
     - Remove /var/log/popularity-contest.$$ when submission fail.
       Closes: #1085020.
   * debian/popularity-contest.8:
     - Apply clean up patch from Bjarni Ingi Gislason. Closes: #1098939.
Checksums-Sha1:
 7359d216c84733e864712cd91f574704a0a316c0 1731 popularity-contest_1.78.dsc
 f3fb8802000352fa52597613a8181e19e39c102b 79888 popularity-contest_1.78.tar.xz
 fe3062f73aea26e71d6cbffd0a073b21696161ab 5563 popularity-contest_1.78_source.buildinfo
Checksums-Sha256:
 7711ddc5686ca1904c27d4daf52e6be23989c300eab6cf994b5a39e39f13d885 1731 popularity-contest_1.78.dsc
 b81c1601c0130ebd3e281ead0320db9d0d529682027003ec082aaecc6810845a 79888 popularity-contest_1.78.tar.xz
 784f15a481f2485e7d4b326443fffeae5f29f0564a8cbe9e645962c7a61050f8 5563 popularity-contest_1.78_source.buildinfo
Files:
 4e514abc3e137baf387655fafd45150e 1731 misc optional popularity-contest_1.78.dsc
 d5a4dbbfc387974cd9b0aec1e8fa4f7b 79888 misc optional popularity-contest_1.78.tar.xz
 a35140941b176cce8c38ae4ab38d6bf2 5563 misc optional popularity-contest_1.78_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQgKOpASi6dgKxFMUjw58K0Ui44cFAmfAg1AACgkQjw58K0Ui
44fXVQ//bGrM+dgo8zQWTO5B25gbgb3Fe91NRxz/JHGrbw+rAGKkJuA71anm8Smj
xk8haOPFGVTMO0nTfIiEVDCrpoWhY0RZPjXE/6hem0oQxb8aNity0N8w3E6/Tclu
CtBCO0yf7pwMGhZoZrZhxv32AxZS21b6MGyKuBjeUJKL6IWbD4uE7qEAcH7tG9ji
zi4JxmlakKnGDDWxereqZtD/FEJ02BBqF3Kx1Hr/zHPHVxKPsQWldpy7hc7axIHW
aGoAqlKRcbgBj919F6JUbh6nCt2Mm2LNVkMCLERePri6DYURKvTVMzjwDLlUeeH5
0A9UzDJnt+a9li+Rw1eOAAmqGqImkd034e5wgSyZUAhCZ8m15xL+EIn4v+90qkPt
JZ+R9CcgQCX162ha/GYgd4Ul4k4152kJiHe54NZ4ok8ISxjCJ0dyyrV4s9TAMQVk
PCXF4ybJueveOhudbIimLQ4WFM/EIuFdkXN2+jTq8Kh76PQxiup4Ircor/BOQeqv
JkBqOZZdC78VKqcPRw9eHgL/qTW3GvhKTxD71ICK7dsrhTMYzZEUJqHqzKnXHrCH
lLiulpBi63UzhfqMVyxDhzwWuc1RbFiVVQsZ2cWfJ10/UVqGjR9NXoEM/nBeK0q/
om0mB3wscJWpJLQwZ7ecS+BX6dy//aEEW08s3+ZUwEVyPkCF8Hw=
=DkHM
-----END PGP SIGNATURE-----

Attachment: pgpf73bmYUWfZ.pgp
Description: PGP signature


--- End Message ---
Reply to: