Bug#960617: popularity-contest: popcon fails to send data if USETOR=maybe and tor is not running

[Michael Krylov <sqarert@gmail.com>]

Package: popularity-contest
Version: 1.67
Severity: normal

Dear Maintainer,

I have noticed that my recent submissions to popularity contest database
have failed. After some further investigation and running

sudo bash -x /etc/cron.daily/popularity-contest

to see what is actually happening, I've noticed that it tries to use
torify to send the submission:

/usr/bin/torify /usr/share/popularity-contest/popcon-upload -u http://popcon.debian.org/cgi-bin/popcon.cgi -f /var/log/popularity-contest.new.gpg

Although I have tor installed, I don't run it all the time, and only
start it on demand.

For now, as a workaround, I set USETOR="no". 

I suggest that this script would check the `service tor status` before
actually using torify if USETOR="maybe" and fail if USERTOR="yes".

Thanks in advance!

-- System Information:
Debian Release: 10.4
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 4.19.0-9-686 (SMP w/4 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages popularity-contest depends on:
ii  debconf [debconf-2.0]  1.5.71
ii  dpkg                   1.19.7

Versions of packages popularity-contest recommends:
ii  cron [cron-daemon]                  3.0pl1-134+deb10u1
pn  default-mta | mail-transport-agent  <none>
ii  gnupg                               2.2.12-1+deb10u1

Versions of packages popularity-contest suggests:
ii  anacron   2.3-28
ii  tor       0.3.5.10-1
ii  torsocks  2.3.0-2

-- debconf information:
* popularity-contest/participate: true
  popularity-contest/submiturls: