[Popcon-developers] HTTP POST support and popcon
- Subject: [Popcon-developers] HTTP POST support and popcon
- From: pere@hungry.com (Petter Reinholdtsen)
- Date: Sun, 03 Jul 2005 09:34:20 +0200
- Message-id: <[🔎] 2flfyuw737n.fsf@saruman.uio.no>
- In-reply-to: <2flvf644t6y.fsf@saruman.uio.no> (Petter Reinholdtsen's message of "Sat, 30 Apr 2005 09:31:01 +0200")
- References: <20050318183218.GR22698@seventeen> <20050318185727.GB20721@saruman.uio.no> <20050318224418.GA20348@seventeen> <20050318225420.GB27363@saruman.uio.no> <20050318234938.GC20348@seventeen> <2flll81pl4t.fsf@saruman.uio.no> <20050414225136.GA12731@seventeen> <2flvf644t6y.fsf@saruman.uio.no>
[Petter Reinholdtsen]
> The code looks fairly good to me. A few comments:
I've commited the code to CVS now, disabled by default.
> - Is there an existing perl module we could use for the HTTP
> communication? I'm not sure we want an extra dependency, but we
> should consider it if we didn't have to add a dependency to get
> access to a library handling this.
I didn't investigate this one yet.
> - There is no timeout. I tried to run the script now, it got stuck.
> I believe it is because of network problems getting to
> popcon.debian.org. The script should try for some seconds, and
> then give up. I suggest using a simple timer.
This need to be added too.
> - The content type used do not mention the compression used, nor that
> this is in fact a plan text file.
I updated it to report x-gzip encoding and text/plain content type.
> - The file name and popcon host should be fetched from the
> configuration files used to specify this, or perhaps we should
> specify it as a command line argument?
I implemented this too.
I'll try to find time to go through the bug list and see if there are
more bugs to close before uploading. I also plan to add a low
priority debconf question to enable the http reporting, to make it
easier for users to enable it.
Bill, did you receive the test reports I submitted yesterday using
http?
Reply to: