Bug#1104643: Don't consider tests during build that can use internet if available as rc buggy

[Sam Hartman <hartmans@debian.org>]

>>>>> "Pirate" == Pirate Praveen <praveen@debian.org> writes:


    Pirate> That was a temporary error. By disabling that test, we are
    Pirate> losing out on useful tests.

I think we absolutely do not want a failure in an external service to
cause a package to FTBFS either on buildds or for individual users.
Ideally we would replicate the network side of a test and run against a
mocked component.
When that is not done (it's a lot of work), I would much rather disable
tests than introduce fragility by having tests that can sometimes fail
when an external service is down.

I also believe the privacy exposure of having code contact external
services is great enough that we should disable tests by default rather
than accept that exposure.

I agree with the option of creating a build option to allow network
access for tests if there are tests you would find useful to run say
from salsa-ci.