Bug#1057238: debian-policy: Take dpkg-build-api into account for Rules-Requires-Root

[Niels Thykier <niels@thykier.net>]

Sean Whitton:
> Hello,
>
> On Tue 13 Aug 2024 at 09:36pm +02, Niels Thykier wrote:
>
> > Can we have a trivial editorial change to the Rules-Requires-Root paragraph
> > saying that default depends on the `dpkg-build-api` used?
> >
> > Bringing it up, because we are seeing a recommendation for people to add a
> > `Rules-Requires-Root: no` even though it is the default and redundant because
> > "policy and lintian said so".
>
> That's not good.  Let's fix this.
>
> It's not quite trivial, because I think we need to say what a
> dpkg-build-api is, somewhere, and how it's selected.
>
> A patch would be welcome and it would still be an informative/editorial
> change that I could just upload, I think.

How about adding

"""
The default for Rules-Requires-Root depends on the dpkg-build-api level 
(the dpkg-build-api is defined in "man 7 dpkg-build-api"). At level 0 
(or when not declared), Rules-Requires-Root defaults to binary-targets. 
In later versions, it defaults to no.
"""

in 5.6.31 and then removing the `(default)` next `binary-targets` in 5.6.31?

I think that would do wonders.

Best regards,
Niels