Bug#1017446: debian-policy: stress that preinst script that install by using base64 decode on self an elf binary is not a good stuff
On Tue, Aug 16, 2022 at 07:22:21AM -0600, Sam Hartman wrote:
> >>>>> "Bastien" == Bastien Roucariès <rouca@debian.org> writes:
> Bastien> I will like to stress that this kind of stuff is bad:
> Bastien> https://salsa.debian.org/debian/isa-support/-/blob/master/debian/altivec-
> Bastien> support.preinst.in#L10
>
> How would you do better in that instance?
> I think everyone knows it's bad, but I'm guessing that the maintainer
> didn't have a better approach for detecting whether the referenced
> instructions worked on the installed system.
>
> I'm assuming that if feature tests in /proc/cpuinfo were sufficient they
> would have been used.
What if the user change their CPU afterward ?
This should probably be tested at boot time instead.
Cheers,
--
Bill. <ballombe@debian.org>
Imagine a large red swirl here.
Reply to: