Hello, On Sat 14 Mar 2020 at 08:09PM +00, Daniel Shahaf wrote: > Daniel Shahaf wrote on Sat, 14 Mar 2020 18:14 +00:00: >> - :: >> - >> - /closes:\s*(?:bug)?\#?\s?\d+(?:,\s*(?:bug)?\#?\s?\d+)*/i >> - >> + All of the bug numbers listed must be given on the same physical line >> + as the word ``closes:``. > > Is this newly-added sentence correct? > > Whether it correctly states the semantics of the regexp depends on > whether the regexp is matched against the changelog entry as a single > multiline string or line-by-line. In the former case, the list of bug > numbers would be allowed to span multiple lines, but in the latter case > it wouldn't. > > Currently, the patch assumes all bug numbers should be on the same line, > but /usr/share/vim/vim81/syntax/debchangelog.vim allows bug numbers to > span multiple lines. I'm guessing the syntax file is right and the patch should > be changed? In PCREs \s matches the newline character so I believe your text is incorrect. -- Sean Whitton
Attachment:
signature.asc
Description: PGP signature