[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#948115: Revise init script Policy based on GR result



Sam Hartman <hartmans@debian.org> writes:

> I've reviewed your patch.
> It looks good.

> One minor suggestion:

> +The ``start``, ``stop``, ``restart``, and ``force-reload`` options should
> +be supported by all init scripts. Supporting ``status`` is recommended but
> +not required. The ``reload`` and ``try-restart`` options are optional.

> How about supporting status is encouraged.
> At this point in the game, do we really want people opening bugs because
> an init script doesn't support status?

> Besides that, LGTM.

I agree with that change and will make that in my version.  Other folks
reviewing this patch, please consider that change as made when deciding
whether to second (and let me know if you object to that change).

Thank you for the review!

-- 
Russ Allbery (rra@debian.org)              <https://www.eyrie.org/~eagle/>


Reply to: