control: tag 1 +patch Hello Karl, Thank you for the new patch. On Sun 20 Jan 2019 at 05:09PM -06, Karl O. Pinc wrote: > I'm 99% confident that _a_ purpose of reboot-required.pkgs > is to provide a list of the packages requiring a reboot > to a human. And notification did not seem to be via logs. > I can't say if the file has any other purpose. > > Regardless of the above, I've made your change as suggested. > The important thing I want to convey is that reboot-required.pkgs > does not affect the reboot signal. It does something supplementary. > Better not to over-specify. Indeed. > It is also worth nothing at this point that kubernetes appears > to be touching reboot-required and adding to reboot-required.pkgs, but > doing so in non-package-installation related code. AFAICT. At least > that's what I recall now after a short glance through the code > some time ago. This is why I added the bit about regular > programs being able to signal for reboot. Okay. >> The ``/run/reboot-required`` mechanism is used when a reboot is >> needed to fully apply the changes introduced by a package >> installation or upgrade. Typically it is the ``postinst`` >> maintainer script that touches ``/run/reboot-required``, at the >> end of a successful configuration of the package. > > I used your text, removing an "a". Hmm, may I ask whether you are a native speaker of English? I am, and it reads better with the 'a', to me. But don't worry, you do not need to prepare a new diff, as I can fix that when committing. > diff --git a/policy/ch-opersys.rst b/policy/ch-opersys.rst > index 59c92ec..8276bfe 100644 > --- a/policy/ch-opersys.rst > +++ b/policy/ch-opersys.rst > @@ -1040,3 +1040,33 @@ Debian, so this section has been removed. > activate the trigger. In that case, it can be done by calling > ``dpkg-trigger --no-await /usr/lib/mime/packages`` from the > maintainer script after creating, modifying, or removing the file. > + > +.. index:: > + pair: signaling; reboot > + > +.. _s-signalingreboot > + > +Signaling that a reboot is required > +----------------------------------- > + > +.. index:: > + single: reboot-required > + single: reboot-required.pkgs > + > +Programs can signal that a reboot is required by ``touch``\ing > +``/run/reboot-required``. It is conventional to add the name of the > +package(s) requiring the reboot to > +``/run/reboot-required.pkgs``. Programs should not add a package name > +to ``/run/reboot-required.pkgs`` if it is already present there. > + > +.. index: > + single: postinst > + > +The ``/run/reboot-required`` mechanism is used when a reboot is > +needed to fully apply the changes introduced by package > +installation or upgrade. Typically it is the ``postinst`` > +maintainer script that touches ``/run/reboot-required``, at the end > +of a successful configuration of the package. > + > +There are no guarantees provided by the ``/var/reboot-required`` > +convention as to when or whether the requested reboot will occur. Seconded. -- Sean Whitton
Attachment:
signature.asc
Description: PGP signature