[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#919507: Reboot required patch for Debian policy



Hello Karl,

Thank you for your patch!

On Fri 18 Jan 2019 at 12:04PM -0600, Karl O. Pinc wrote:

> +Signaling that a reboot is required
> +-----------------------------------

By inserting the text here you will cause other sections of Policy to be
renumbered.  It should be added later in the chapter to avoid that.  But
don't worry, I can fix that when applying the patch.

> +Maintainer scripts can signal that a reboot is required to fully apply
> +the changes to the system by touching ``/run/reboot-required`` and
> +adding the package name to ``/run/reboot-required.pkgs``. Maintainer
> +scripts should not add the package name to
> +``/run/reboot-required.pkgs`` if it is already present there.

Are you sure that adding the package name to the .pkgs file is required?
I've not seen that file on my system; it seems that only
/run/reboot-required is used.  Balint said that the .pkgs is an Ubuntu
thing; are you sure it has been upstreamed into Debian?

> +
> +The appropriate place to do this is expected to be when the
> +``postinst`` script is called as ``postinst configure
> +most-recently-configured-version``.
> +
> +Ordinary programs may manipulate these files to signal that a reboot
> +is required.
> +

This is a bit awkward.  You describe this feature in terms of maintainer
scripts and then say that programs can use it too.  It would be better
to put it in ch. 9 or ch. 10, I think, and describe it in more general
terms.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: