Bug#850156: Please firmly deprecate vendor-specific series files
On Thu, 19 Apr 2018 at 08:00:28 +0000, Mike Gabriel wrote:
> One example, where the vendor.series file is really helpful is:
> https://anonscm.debian.org/cgit/pkg-mate/mate-terminal.git/tree/debian/patches/2001_fix-find-next-previous.patch
That one-line change could easily be guarded by
#ifdef UBUNTU_PATCHED_LIBVTE or something, with
CPPFLAGS += -DUBUNTU_PATCHED_LIBVTE in debian/rules whenever dpkg-vendor
says you're compiling for Ubuntu.
Alternatively, looking at the Ubuntu vte patch, this pseudo-patch should
work either way:
-can_search = vte_terminal_search_get_regex (VTE_TERMINAL (screen)) != NULL;
+can_search = (vte_terminal_search_get_regex (VTE_TERMINAL (screen)) != NULL ||
+ vte_terminal_search_get_gregex (VTE_TERMINAL (screen)) != NULL);
... and indeed the Ubuntu side of the #ifdef should really be something
more like that anyway, because otherwise, if Ubuntu add pcre2 to main
and stop patching libvte, mate-terminal search on Ubuntu will stop working
again (this time for the opposite reason).
smcv
Reply to: