[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#515856: [debhelper-devel] Bug#515856: debhelper: please implement dh get-orig-source



control: tag -1 -patch +pending

Hello,

On Mon, Sep 18, 2017 at 01:01:19PM +0200, Bill Allombert wrote:
> On Mon, Sep 18, 2017 at 12:38:49PM +0200, Helmut Grohne wrote:
> > On Mon, Sep 18, 2017 at 11:28:42AM +0200, Bill Allombert wrote:
> > > get-orig-source and watch files serve a different purpose.
> > > 
> > > get-orig-source is used to build the .orig. tarball from the true
> > > upstream one. Most package do not need that.  Watch files could not do
> > > that until recently.
> > > 
> > > So the comparaison is unfair.
> > > 
> > > What need to be checked is how many get-orig-source rules has been
> > > reimplemented in term of watch files.
> > 
> > Challenge accepted. ticharich.d.o has an unpack of rules debian/rules
> > files. Most of them are world-readable. A small number (~30) are
> > inaccessible, so my analysis will have an error of around 0.2%.
> > 
> > A simple method is to just look at which of them contain the string
> > "get-orig-source" and which of them contain the string "uscan" assuming
> > that when both show up, get-orig-source is implemented using uscan.
> 
> One would need to check whether get-orig-source use uscan for repacking
> or if it only use uscan for downloading and then repack manually.

Good point, but note that such cases can almost certainly migrate to
uscan -- and if they can't, that's a bug in uscan.

We're not rendering those packages buggy with this change, because it's
fine to continue to have a get-orig-source target.  We're just reducing
the documented interfaces of packages a bit based on current trends,
which is useful for newcomers to Debian.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: