[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#835520: Seconding nine patches & seeking seconds for two more



gregor herrmann <gregoa@debian.org> writes:
> On Thu, 03 Aug 2017 10:55:30 -0400, Sean Whitton wrote:

>> I've spoken to h01ger and gregoa IRL and they say that they missed the
>> magic word "should" which is what makes debhelper required by these
>> patches.  So I'm seeking seconds for the following replacement for
>> Andreas' 5th and 8th patches:

> Indeed, I missed the magic "should" which unfortunately didn't come
> in friendly bold red blinking letters :)

> Thanks for catching this glitch, and I'm happy to second the improved
> version:

I also second the improved version.  Thank you!

>> diff --git a/policy.xml b/policy.xml
>> index 3daa532..c6c7412 100644
>> --- a/policy.xml
>> +++ b/policy.xml
>> @@ -8525,6 +8525,14 @@ fi</programlisting>
>>              <literal>update-rc.d</literal>, please consult its man page
>>              <citerefentry><refentrytitle>update-rc.d</refentrytitle><manvolnum>8</manvolnum></citerefentry>.
>>            </para>
>> +          <para>
>> +            It is easiest for packages not to call
>> +            <command>update-rc.d</command> directly, but instead use
>> +            debhelper programs that add the required
>> +            <command>update-rc.d</command> calls automatically.  See
>> +            <command>dh_installinit</command>,
>> +            <command>dh_systemd_enable</command>, etc.
>> +          </para>
>>          </section>
>>  
>>          <section id="s9.3.3.2">
>> @@ -8573,6 +8581,14 @@ invoke-rc.d <replaceable>package</replaceable> <replaceable>action</replaceable>
>>              <command>invoke-rc.d</command>, please consult its man page
>>              <citerefentry><refentrytitle>invoke-rc.d</refentrytitle><manvolnum>8</manvolnum></citerefentry>.
>>            </para>
>> +          <para>
>> +            It is easiest for packages not to call
>> +            <command>invoke-rc.d</command> directly, but instead use
>> +            debhelper programs that add the required
>> +            <command>invoke-rc.d</command> calls automatically.  See
>> +            <command>dh_installinit</command>,
>> +            <command>dh_systemd_start</command>, etc.
>> +          </para>
>>          </section>
>>  
>>        </section>

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>


Reply to: