[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#704657: debian/rules: Inconsistent required targets



On Thu, Apr 04, 2013 at 09:59:06AM -0700, Russ Allbery wrote:
> Charles Plessy <plessy@debian.org> writes:
> 
> > Would people be satisifed of the following change as a non-normative
> > correction, given that the build-arch and build-indep are already marked
> > required by the commit above ?
> 
> >           The following targets are required and must be implemented
> >           by <file>debian/rules</file>: <tt>clean</tt>, <tt>binary</tt>,
> > -         <tt>binary-arch</tt>, <tt>binary-indep</tt>, and <tt>build</tt>.
> > +         <tt>binary-arch</tt>, <tt>binary-indep</tt>, <tt>build</tt>,
> > +         <tt>build-arch</tt> and <tt>build-indep</tt>.
> >           These are the targets called by <prgn>dpkg-buildpackage</prgn>.
> 
> Yes, it looks good to me.

Likewise, this looks fine to me.

> > PS: The autobuilder are still calling 'build' not 'build-arch', don't
> > they ?
> 
> No, I believe dpkg has been changed to probe whether the build-arch target
> exists and call it by preference if it does, and I think that change is
> already live on the buildds.

The change was implemented in dpkg 1.16.2 just over a year ago.

However, the intention is that the probing/autodetection is only
a transitional measure, and this will be removed once the transition
is complete.  Once wheezy is released, lintian can make missing
build-arch and build-indep targets an error rather than a warning,
and then we can aim to fix up the remaining packages for jessie.
I'll be doing some whole-archive rebuilds once wheezy is out to
assess the scale of what percentage of the archive still needs
attention.  Once we're done with the transition, dpkg can then
drop the autodetection logic by default.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


Reply to: