[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#690293: Policy 5.6.24: Checksums-{SHA1,SHA256} are required by the archive software



user debian-policy@packages.debian.org
usertags 690293 normative discussion
thanks

Le Fri, Oct 12, 2012 at 09:31:24AM +0200, Ansgar Burchardt a écrit :
> 
> The Checksums-{SHA1,SHA256} fields were optional when they were
> documented in Policy[1], but by now dak requires Checksums-{SHA1,SHA256}
> to be present and listing all files in both .dsc and .changes files.
> 
>   [1] <http://bugs.debian.org/478295#73>
> 
> I suggest replacing both 'should's with 'must' in the paragraph quoted
> above.

Thanks a lot for the feedback !  How about the following patch ?  Instead
of replacing shoulds by musts, it:

 - Replaces "required" by "mandatory" in the list of fields for the Debian
   source control and Debian changes files.

 - Removes the "shoulds" that I think are misleading.  Even if the fields
   were still only recommended, I think that they must not be used for
   other purposes or with another syntax.

Have a nice week-end,

-- 
Charles Plessy
Tsurumi, Kanagawa, Japan
>From e5b6764863b3cde0eaafa3ac06986d16b82c98a2 Mon Sep 17 00:00:00 2001
From: Charles Plessy <plessy@debian.org>
Date: Sat, 13 Oct 2012 11:48:46 +0900
Subject: [PATCH] Checksums-Sha1 and Checksums-Sha256 are required by dak and
 therefore mandatory

Closes: #690293
See also: http://bugs.debian.org/478295#73
---
 policy.sgml |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/policy.sgml b/policy.sgml
index 5760a3f..1ca060c 100644
--- a/policy.sgml
+++ b/policy.sgml
@@ -2754,7 +2754,7 @@ Package: libc6
 	  <item><qref id="f-Standards-Version"><tt>Standards-Version</tt></qref> (recommended)</item>
 	  <item><qref id="sourcebinarydeps"><tt>Build-Depends</tt> et al</qref></item>
 	  <item><qref id="f-Checksums"><tt>Checksums-Sha1</tt>
-	      and <tt>Checksums-Sha256</tt></qref> (recommended)</item>
+	      and <tt>Checksums-Sha256</tt></qref> (mandatory)</item>
 	  <item><qref id="f-Files"><tt>Files</tt></qref> (mandatory)</item>
 	</list>
 	</p>
@@ -2807,7 +2807,7 @@ Package: libc6
 	    <item><qref id="f-Closes"><tt>Closes</tt></qref></item>
 	    <item><qref id="f-Changes"><tt>Changes</tt></qref> (mandatory)</item>
 	    <item><qref id="f-Checksums"><tt>Checksums-Sha1</tt>
-		and <tt>Checksums-Sha256</tt></qref> (recommended)</item>
+		and <tt>Checksums-Sha256</tt></qref> (mandatory)</item>
 	    <item><qref id="f-Files"><tt>Files</tt></qref> (mandatory)</item>
 	  </list>
 	</p>
@@ -3741,9 +3741,9 @@ Checksums-Sha256:
 	  </p>
 
 	  <p>
-	    In the <file>.dsc</file> file, these fields should list all
+	    In the <file>.dsc</file> file, these fields list all
 	    files that make up the source package.  In
-	    the <file>.changes</file> file, these fields should list all
+	    the <file>.changes</file> file, these fields list all
 	    files being uploaded.  The list of files in these fields
 	    must match the list of files in the <tt>Files</tt> field.
 	  </p>
-- 
1.7.10.4


Reply to: