[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#660193: developers-reference: please suggest debian/rules target name for preparing source



On Sat, 17 Mar 2012, Carsten Hey wrote:
> > prebuild:
> >       test ! -d wafadmin
> >       ./waf --help >/dev/null
> >       mv .waf-*/wafadmin .
> >       rm -f .waf-*/t.bz2
> >       rmdir .waf-*
> >       sed -n -i -e '1,/^#==>$$/ p' -e '/^#<==$$/,$$ p' waf

Maybe this would work?

prebuild: prebuild-stamp
	(do interesting stuff here)
	echo stamp > prebuild-stamp

clean:	prebuild
	...

get-source:
        rm -f prebuild-stamp
        ...

dpkg-source will carry prebuild-stamp in the diff, and since it updates
the timestamp of anything it patches, and clean is a phony target, it
should not decide that prebuild is outdated and needs a rebuild.

If it does run, guarding the relevant shell stuff with 
	if ! [ -e prebuild-stamp ]
should be obvious enough and easier to understand than the other
techniques to avoid timestamp skews.

> have been 'extract-waf'.  All this bug report is about is that in such
> cases maintainers should consider using prebuild as the target's name
> instead of inventing new ones.

To me it looks like "clean" should be able to do this job without any
changes to dpkg-source and friends.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh



Reply to: