[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#658009: debian-policy: dpkg-buildpackage -rroot-command out of date



Le Mon, Jan 30, 2012 at 12:56:52PM -0600, Jonathan Nieder a écrit :
> Sam Morris wrote:
> 
> > C.1.2 says:
> >
> > 	If no root-command is supplied then dpkg-buildpackage will take
> > 	no special action to gain root privilege, so that for most
> > 	packages it will have to be invoked as root to start with.
> >
> > This is wrong according to the dpkg-buildpackage man page
> 
> True.  How about this patch?

Hi Jonathan,

I think that it is a bit drastic.  In the case of dpkg-buildpackage,
I agree that we should not repeat information found in the manual page,
but I like the short explanations on the purpose of each Dpkg helper
tool.

How about limiting the deletions to the following.

> -	    <taglist compact="compact">
> -	      <tag><tt>-uc</tt>, <tt>-us</tt></tag>
> -	      <item>
> -		<p>
> -		  Do not sign the <tt>.changes</tt> file or the
> -		  source package <tt>.dsc</tt> file, respectively.</p>
> -	      </item>
> -	      <tag><tt>-p<var>sign-command</var></tt></tag>
> -	      <item>
> -		<p>
> -		  Invoke <var>sign-command</var> instead of finding
> -		  <tt>gpg</tt> or <tt>pgp</tt> on the <prgn>PATH</prgn>.
> -		  <var>sign-command</var> must behave just like
> -		  <prgn>gpg</prgn> or <tt>pgp</tt>.</p>
> -	      </item>
> -	      <tag><tt>-r<var>root-command</var></tt></tag>
> -	      <item>
> -		<p>
> -		  When root privilege is required, invoke the command
> -		  <var>root-command</var>.  <var>root-command</var>
> -		  should invoke its first argument as a command, from
> -		  the <prgn>PATH</prgn> if necessary, and pass its
> -		  second and subsequent arguments to the command it
> -		  calls.  If no <var>root-command</var> is supplied
> -		  then <var>dpkg-buildpackage</var> will take no
> -		  special action to gain root privilege, so that for
> -		  most packages it will have to be invoked as root to
> -		  start with.</p>
> -	      </item>
> -	      <tag><tt>-b</tt>, <tt>-B</tt></tag>
> -	      <item>
> -		<p>
> -		  Two types of binary-only build and upload - see
> -		  <manref name="dpkg-source" section="1">.
> -		</p>
> -	      </item>
> -	    </taglist>

(plus removing "; useful arguments include:" in the second paragraph).

Have a nice day,

-- 
Charles Plessy
Tsurumi, Kanagawa, Japan



Reply to: