Re: [RFC] Skipping new-prerm failed-upgrade?
Raphael Hertzog wrote:
> - maintainer_script_alternative(pkg, PRERMFILE, "pre-removal", cidir, cidirrest,
> - "upgrade", "failed-upgrade");
> + if (versioncompare(&pkg->available.version,
> + &pkg->installed.version) > 0) /* Upgrade */
> + maintainer_script_alternative(pkg, PRERMFILE, "pre-removal", cidir, cidirrest,
> + "upgrade", "failed-upgrade");
> + else /* Downgrade => no fallback */
> + maintainer_script_installed(pkg, PRERMFILE, "pre-removal", "upgrade",
> + versiondescribe(&pkg->available.version,
> + vdew_nonambig), NULL);
I suppose I would be happier with the condition being ">= 0", to make
it slightly more likely that the failed-upgrade code gets well tested
(though I don't think it matters much). Aside from that, looks very
sane. Thanks for thinking about these things.
Jonathan
Reply to: