Bug#622263: debian-policy: Phrasing of 5.6.25 (DMUA) is confusing

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

On Mon, 2011-04-11 at 16:54 +0200, Didier Raboud wrote:
> We just had a short discussion on IRC (#debian-python, 2011-04-11) about the
> phrasing of the new 5.6.25 paragraph (which documents the DMUA field).
> 
> The current phrasing makes it sound that adding the DM-Upload-Allowed field
> to each source package is required (where AFAIK it isn't).

Hmmm.  My reading of the dak code suggests that it *is* required each
time.  For instance, daklib/queue.py contains:

  r = get_newest_source(self.pkg.changes["source"], session)
  [...]
  if not r.dm_upload_allowed:
    rej = "Source package %s does not have 'DM-Upload-Allowed: yes' in its most recent version (%s)" % (self.pkg.changes["source"], r.version)
    self.rejects.append(rej)

and from dbconn.py:

  source.dm_upload_allowed = (u.pkg.dsc.get("dm-upload-allowed", '') == "yes")

The wording for the GR which established the DM process
(<URL:http://www.debian.org/vote/2007/vote_003>) also explicitly says
"the most recent version [...] includes the field "DM-Upload-Allowed:
yes" [...] lists the uploader in the Maintainer: or Uploaders: fields"

Regards,

Adam