Bug#613046: debian-policy: please update example in 4.9.1 (debian/rules and DEB_BUILD_OPTIONS)

[Julien Cristau <jcristau@debian.org>]

On Sat, Feb 12, 2011 at 14:25:40 +0100, Niels Thykier wrote:

> Package: debian-policy
> Version: 3.9.1.0
> Severity: minor
> 
> Hey
> 
> The example in 4.9.1 suggests to set CFLAGS in a way that completely
> overrides values from dpkg-buildpackage/dpkg-buildflags[1]:
> 
> CFLAGS = -Wall -g
> 
> This will set CFLAGS to "-Wall -g" regardless of what dpkg-buildflags
> provides.  Possible alternatives that appears to work are:
> 
> CFLAGS := $(CFLAGS) -Wall -g
> 
That would be wrong.  A package build shouldn't depend on random env
variables.

> CFLAGS  = $(shell dpkg-buildflags --get CFLAGS) -Wall -g
> 
> While related to #578597, I believe it to be a distinct issue. This was triggered
> by this email[2] on debian-mentors.
> 
Seems to be the exact same request to me?

Cheers,
Julien