[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#578597: Recommend usage of dpkg-buildflags to initialize CFLAGS and al.



        Hey

 Great to this see effort!

On Wed, Apr 21, 2010, Raphael Hertzog wrote:
> The desired outcome is that all package grab the values directly from
> dpkg-buildflags and that we can stop exporting the variables from
> dpkg-buildpackage. That way calling debian/rules directly and via
> dpkg-buildpackage should give the same result.

 I wonder why would we ever want to remove the exports?  To prevent
 accidental pickup of *FLAGS from the env?

> CFLAGS=$(shell dpkg-buildflags --get CFLAGS)

 Would it make sense to recommend:
    CFLAGS ?= $(shell dpkg-buildflags --get CFLAGS)
 instead?

 Or perhaps:
    DEB_CFLAGS_SET ?= $(shell dpkg-buildflags --get CFLAGS)
    [...]
    ./configure CFLAGS="$(DEB_CFLAGS_SET)"

 I see that's not in the man page, not sure it would make sense in
 policy either.

    Thanks
-- 
Loïc Minier



Reply to: