[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 1/1] Use the "Half-Configured" state instead of the synonymous "Failed-Config"



Hi!

On Sun, 2009-11-22 at 22:01:30 -0600, Manoj Srivastava wrote:
> These terms are synonyms. dpkg and dselect use halfconfigured
> internally and used to use Failed-config when talking to the user in
> soe cases. This patch ensures that policy uses the same term as dpkg
> does when talking to the user ("Half-Configured") for consistency.
> 
> Also, made the spelling of internal states consistent:
>  "Half-Configured",
>  not: Half Configured, half configured, or half-configured.

I see you've also made config-files and half-installed consistent,
might be worth mentioning in the commit message (or split into another
commit). It might also be worthwhile to do the same for the rest of
the states.

> Signed-off-by: Manoj Srivastava <srivasta@debian.org>
> ---
>  policy.sgml |   26 +++++++++++++-------------
>  1 files changed, 13 insertions(+), 13 deletions(-)
>
[...]
> @@ -4417,12 +4417,12 @@ Build-Depends: foo [!i386] | bar [!amd64]
>  		be <em>unpacked</em> the pre-dependency can be
>  		satisfied if the depended-on package is either fully
>  		configured, <em>or even if</em> the depended-on
> -		package(s) are only unpacked or half-configured,
> -		provided that they have been configured correctly at
> -		some point in the past (and not removed or partially
> -		removed since).  In this case, both the
> +		package(s) are only unpacked or in the "Half-Configured"
> +		state, provided that they have been configured
> +		correctly at some point in the past (and not removed
> +		or partially removed since).  In this case, both the
>  		previously-configured and currently unpacked or
> -		half-configured versions must satisfy any version
> +		Half-Configured versions must satisfy any version

Missing quotes.

>  		clause in the <tt>Pre-Depends</tt> field.
>  	      </p>
>  
> @@ -4479,7 +4479,7 @@ Build-Depends: foo [!i386] | bar [!amd64]
>  	<p>
>  	  A package will not be regarded as causing breakage merely
>  	  because its configuration files are still installed; it must
> -	  be at least half-installed.
> +	  be at least Half-Installed.
>  	</p>

Likewise.

> @@ -4533,7 +4533,7 @@ Build-Depends: foo [!i386] | bar [!amd64]
>  	<p>
>  	  A package will not cause a conflict merely because its
>  	  configuration files are still installed; it must be at least
> -	  half-installed.
> +	  Half-Installed.
>  	</p>

Likewise.

With those fixed, seconded.

regards,
guillem

Attachment: signature.asc
Description: Digital signature


Reply to: