Re: Environment variables, debian/rules and dpkg-buildpackage
On Sun, May 10 2009, Raphael Hertzog wrote:
> On Sun, 10 May 2009, Steve Langasek wrote:
>> I'm really surprised to see this approach getting traction. To me, this
>> seems like a significant, unprecedented departure from the kinds of
>> interfaces we've mandated in Policy in the past (i.e., environment
>> variables, executables and command-line options). While one build helper or
>> another may mandate Makefile includes, there's never been anything of the
>> sort in Policy, and I don't think it's good to add such a thing now. I
>> thought it was generally recognized that it's a Bad Idea to implement config
>> files using your interpreter's 'include' functionality, but that's basically
>> what we have here.
BTW, the goal of policy is to enshrine the right thing, not to
enshrine tradition, or The Way Things Have Always Been Done.
In this case, the proposal seems to meet the goals:
i) Provide a way for project wide build variables and flags to be
implemented
ii) Allow a set to override these values, augment them, or set new
ones.
iii) Allow a package to override or augment the site values.
iv) Allow a use to override or augment any of the above.
How a proposal meets the goals should be immaterial, as long as
it does so correctly.
The fact that we need caution in setting project wide values for
these things is a given, and a separate issue.
> Another negative aspect of the include approach is the lack of
> tracability. Right now when the user overrides a build flag it appears
> in the build log since dpkg-buildpackage prints it out in the log:
> dpkg-buildpackage: use CFLAGS from environment: -O3 -Wall
>
> With the include approach, we lack this feature and bad/broken local
> overrides can't be detected if we only have the build log at hand.
Sure they can. Have the site file bundles in with the
report. Broken setups can be easily read there,
manoj
--
Bernard Shaw is an excellent man; he has not an enemy in the world, and
none of his friends like him either. -- Oscar Wilde
Manoj Srivastava <srivasta@debian.org> <http://www.debian.org/~srivasta/>
1024D/BF24424C print 4966 F272 D093 B493 410B 924B 21BA DABB BF24 424C
Reply to: