Bug#430649: New proposed wording for DEB_BUILD_OPTIONS
Loïc Minier <lool@dooz.org> writes:
> On Sun, Dec 30, 2007, Russ Allbery wrote:
>> Comments? Seconds?
>
> Thanks for your wording!
>
>> +ifneq (,$(filter noopt,$(DEB_BUILD_OPTIONS)))
>> + CFLAGS += -O0
>> +else
>> + CFLAGS += -O2
>> +endif
>
> I personally use:
>
> CFLAGS += -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
>
> in my packages; perhaps slightly harder to read the first time, but
> soon becomes a well known line which eats less space.
That's certainly a reasonable thing to do, but I'm inclined to not mess
with this part of the example since it's been in Policy for ages and does
work. (Although I did change findstring to filter to be consistent with
the change in requiring space separation and to avoid triggering on parts
of other options, so I suppose I did open the door to changing other
things about it too.) There is a warning that it's just an example and
maintainers are free to do other things.
I'm happy to change, though, if there's a consensus that the example
should be different.
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to: