[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#346598: init script stop example should use --oknodo



On Sun, 08 Jan 2006, Matt Kraai wrote:
> According to the LSB Core Specification 3.1, init scripts should
> consider running stop on a service already stopped or not running
> successful, but the example in policy does not behave this way because
> it does not pass --oknodo to start-stop-daemon in the stop case.  The
> attached patch makes it do so.

It must also use retry or some other way to make sure the daemon indeed
stopped, and we should add a comment that you cannot use --exec if:
 1. the daemon isn't an ELF executable (i.e. no #! stuff can use --exec)
 2. the daemon could be running when its executable was replaced by a
    package upgrade.

Or remove that error-inducing example completely and tell people to read
/etc/init.d/skeleton (which is easier to fix than policy :-) ).

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh



Reply to: