[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#139466: dh-make: Sample init.d's output should follow policy's suggestion

Package: dh-make
Version: 0.30
Severity: normal
Tags: patch

[CC'd to -policy for comment]


The debian/init.d.ex script that dh_make installs into new packages has
different output than what policy suggests; it only prints the
"Starting xxx: " message before the daemon is started, whereas policy
suggestions print "Starting xxx: xxxd" before the daemon is started,
then print the "." after the daemon has been successfully started (see
policy section 10.4)

IMO policy's suggested way of doing things is much better than the
current suggestion in dh_make, as if something goes wrong with a daemon
(say the system goes into a hardware lockup every time a daemon is
started), it's much easier to trace this.

Note to people on -policy: it would be great if this was standardised
more, for consistency's sake. Currently we have packages using both
methods (printing the daemon name before/after the daemon is started).

*** patch against /usr/share/debhelper/dh_make/debian/init.d.ex ***
--- init.d.ex.orig	Sat Mar 23 00:18:25 2002
+++ init.d.ex	Sat Mar 23 00:19:17 2002
@@ -22,16 +22,16 @@
 case "$1" in
-	echo -n "Starting $DESC: "
+	echo -n "Starting $DESC: $NAME"
 	start-stop-daemon --start --quiet --pidfile /var/run/$NAME.pid \
 		--exec $DAEMON
-	echo "$NAME."
+	echo "."
-	echo -n "Stopping $DESC: "
+	echo -n "Stopping $DESC: $NAME"
 	start-stop-daemon --oknodo --stop --quiet --pidfile /var/run/$NAME.pid \
 		--exec $DAEMON
-	echo "$NAME."
+	echo "."
@@ -51,13 +51,13 @@
 	#	option to the "reload" entry above. If not, "force-reload" is
 	#	just the same as "restart".
-	echo -n "Restarting $DESC: "
+	echo -n "Restarting $DESC: $NAME"
 	start-stop-daemon --stop --quiet --pidfile \
 		/var/run/$NAME.pid --exec $DAEMON
 	sleep 1
 	start-stop-daemon --start --quiet --pidfile \
 		/var/run/$NAME.pid --exec $DAEMON
-	echo "$NAME."
+	echo "."
*** end patch ***



-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux pippin 2.4.17-xfs-k6 #1 Tue Jan 8 22:25:38 EST 2002 i586

Versions of packages dh-make depends on:
ii  debhelper                     3.4.12     helper programs for debian/rules
ii  dpkg-dev                      1.9.20     Package building tools for Debian
ii  make                          3.79.1-13  The GNU version of the "make" util
ii  perl                          5.6.1-7    Larry Wall's Practical Extraction 

   Timshel Knoll <timshel@pobox.com>, Debian email: <timshel@debian.org>
          Debian GNU/Linux developer: http://people.debian.org/~timshel/
                             GnuPG public key: finger timshel@debian.org

Reply to: