[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#69487: the example for using nostrip in DEB_BUILD_OPTIONS is incorrect



On Sun, Aug 20, 2000 at 04:24:09PM -0400, Ben Collins wrote:
> > ifneq "$(findstring debug,$(DEB_BUILD_OPTIONS))" ""
> >   CFLAGS += -g
> > endif
> > ifeq "$(findstring nostrip,$(DEB_BUILD_OPTIONS))" ""
> >   INSTALL += -s
> > endif
> 
> The nostrip check needs to be inside the debug check. Because of you are
> not compiling with debugging turned on, there's no reason to not strip the
> binaries.

Same difference...

> So (note, the blank should go first):

I see no reason why, it works just fine when it's second. And it's more
alike to the human way of thinking (`if string equals nothing' compared to
`if nothing equals string'). :)

> Also, I think Joey is likely to add nostrip detection to dh_strip, which
> means for packages that use that, they wont need to detect the nostrip
> option.

Yes, that would be useful. Although, the makefiles of individual packages
should still need to be checked, some of them do stripping automatically.

-- 
Digital Electronic Being Intended for Assassination and Nullification



Reply to: