Bug#36619: marked as done ([REJECTED] Allowable values of PAGER variable should be described in policy)
Your message dated Wed, 21 Jun 2000 19:19:05 +0100
with message-id <20000621191905.A4593@polya>
and subject line Bug#36619: [REJECTED] Allowable values of PAGER variable should be described in policy
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 24 Apr 1999 11:10:51 +0000
Received: (qmail 13194 invoked from network); 24 Apr 1999 11:10:50 -0000
Received: from unknown (HELO athena.binmedia.com) (207.240.149.5)
by master.debian.org with SMTP; 24 Apr 1999 11:10:50 -0000
Received: from yelm.east.bacchus.com (ccwf@5019baccus.015.popsite.net [207.240.250.235])
by athena.binmedia.com (8.8.8/8.8.8) with ESMTP id EAA23992
for <submit@bugs.debian.org>; Sat, 24 Apr 1999 04:10:46 -0700
Received: (from ccwf@localhost)
by yelm.east.bacchus.com (8.9.3/8.9.3/Debian/GNU) id EAA21491;
Sat, 24 Apr 1999 04:10:07 -0700
Sender: ccwf@bacchus.com
To: submit@bugs.debian.org
Subject: $PAGER does not work if it includes options
From: ccwf@bacchus.com (Charles C. Fu)
MIME-Version: 1.0 (generated by SEMI 1.13.3 - "Komaiko")
Content-Type: multipart/mixed;
boundary="Multipart_Sat_Apr_24_04:09:50_1999-1"
Date: 24 Apr 1999 04:10:06 -0700
Message-ID: <877lr25l69.fsf@yelm.east.bacchus.com>
Lines: 165
User-Agent: Chao-gnus/6.12.5 SEMI/1.13.3 (Komaiko) FLIM/1.12.5 (Hirahata) MULE XEmacs/20.4 (Emerald) (i386-debian-linux)
Package: wdiff
Version: 0.5-7
Severity: wishlist
--Multipart_Sat_Apr_24_04:09:50_1999-1
Content-Type: text/plain; charset=US-ASCII
wdiff dies with an exit code of 2 if $PAGER is an executable with
arguments (e.g., "less -c"). This bug can be fixed simply by using
popen instead of wdiff's writepipe function as shown in the attached
patch.
Using popen means that a shell will be invoked which will parse any
metacharacters (e.g., consider the PAGER string "sleep 500& less -c").
Such handling is consistent with the behavior of Debian programs
including zmore and /usr/bin/man and is somewhat consistent with the
program /usr/bin/mail (which has a custom globbing routine that
interprets a limited set of metacharacters).
Since the PAGER environment variable is used by many packages and is
currently parsed at least three different ways, perhaps Debian policy
should state what is allowed in $PAGER.
--
,-- Charles C. Fu ccwf@bacchus.com
___ __ __. . ,-/-- Vice President TEL: (310)820-9145
(_,(_,|/|/ / Bacchus, Inc. FAX: (310)820-5930
--' http://www.bacchus.com/
--Multipart_Sat_Apr_24_04:09:50_1999-1
Content-Type: application/octet-stream; type=patch
Content-Disposition: attachment; filename="wdiff_0.5.diff"
Content-Transfer-Encoding: 7bit
diff -Nur wdiff-0.5.orig/Makefile.in wdiff-0.5/Makefile.in
--- wdiff-0.5.orig/Makefile.in Sat Nov 5 23:45:13 1994
+++ wdiff-0.5/Makefile.in Sat Apr 24 03:57:52 1999
@@ -73,8 +73,8 @@
INCLUDES = -I. -I$(srcdir)
HEADERS =
-SOURCES = wdiff.c readpipe.c writepipe.c
-OBJECTS = wdiff$O readpipe$O writepipe$O
+SOURCES = wdiff.c readpipe.c
+OBJECTS = wdiff$O readpipe$O
LIBHDRS = getopt.h pathmax.h
LIBSRCS = error.c getopt.c getopt1.c alloca.c strstr.c xmalloc.c
LIBOBJS = error.o getopt.o getopt1.o @ALLOCA@ @LIBOBJS@
diff -Nur wdiff-0.5.orig/wdiff.c wdiff-0.5/wdiff.c
--- wdiff-0.5.orig/wdiff.c Sat Apr 24 03:56:27 1999
+++ wdiff-0.5/wdiff.c Sat Apr 24 03:57:18 1999
@@ -95,7 +95,6 @@
char *getenv ();
FILE *readpipe _((const char *, ...));
-FILE *writepipe _((const char *, ...));
char *tmpnam ();
void error ();
@@ -956,7 +955,7 @@
if (program && *program)
{
- output_file = writepipe (program, NULL);
+ output_file = popen (program, "w");
if (!output_file)
error (EXIT_OTHER_REASON, errno, program);
diff -Nur wdiff-0.5.orig/writepipe.c wdiff-0.5/writepipe.c
--- wdiff-0.5.orig/writepipe.c Sun Nov 6 00:03:32 1994
+++ wdiff-0.5/writepipe.c Wed Dec 31 16:00:00 1969
@@ -1,92 +0,0 @@
-/* Open a pipe to write to a program without intermediary sh.
- Copyright (C) 1992 Free Software Foundation, Inc.
-
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation; either version 2, or (at your option)
- any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
-
- You should have received a copy of the GNU General Public License
- along with this program; if not, write to the Free Software
- Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */
-
-/* Written by David MacKenzie. */
-
-#if HAVE_CONFIG_H
-# include "config.h"
-#endif
-
-#include <stdio.h>
-
-#if __STDC__
-#include <stdarg.h>
-#else
-#include <varargs.h>
-#endif
-
-#if HAVE_UNISTD_H
-# include <unistd.h>
-#endif
-
-/* Open a pipe to write to a program without intermediary sh. Checks
- PATH. Sample use:
-
- stream = writepipe ("progname", "arg1", "arg2", (char *) 0);
-
- Return 0 on error. */
-
-#if __STDC__
-FILE *
-writepipe (char *progname, ...)
-#else
-FILE *
-writepipe (...)
-#endif
-{
-#if ! __STDC__
- char *progname;
-#endif
- int fds[2];
- va_list ap;
- char *args[100];
- int argno = 0;
-
- /* Copy arguments into `args'. */
-#if __STDC__
- va_start (ap, progname);
-#else
- va_start (ap);
- progname = va_arg (ap, char *);
-#endif
- args[argno++] = progname;
- while ((args[argno++] = va_arg (ap, char *)) != NULL)
- ;
- va_end (ap);
-
- if (pipe (fds) == -1)
- return 0;
-
- switch (fork ())
- {
- case 0: /* Child. Read from pipe. */
- close (fds[1]); /* Not needed. */
- if (fds[0] != 0) /* Redirect 0 (stdin) only if needed. */
- {
- close (0); /* We don't want the old stdin. */
- dup (fds[0]); /* Guaranteed to dup to 0 (stdin). */
- close (fds[0]); /* No longer needed. */
- }
- execvp (args[0], args);
- _exit (2); /* 2 for `cmp'. */
- case -1: /* Error. */
- return 0;
- default: /* Parent. Write to pipe. */
- close (fds[0]); /* Not needed. */
- return fdopen (fds[1], "w");
- }
-}
--Multipart_Sat_Apr_24_04:09:50_1999-1--
---------------------------------------
Received: (at 36619-done) by bugs.debian.org; 21 Jun 2000 18:20:12 +0000
>From J.D.Gilbey@qmw.ac.uk Wed Jun 21 13:20:12 2000
Return-path: <J.D.Gilbey@qmw.ac.uk>
Received: from mserv1c.u-net.net [195.102.240.33]
by master.debian.org with esmtp (Exim 3.12 2 (Debian))
id 134p6i-0002E5-00; Wed, 21 Jun 2000 13:20:12 -0500
Received: from [195.102.197.253] (helo=polya)
by mserv1c.u-net.net with esmtp (Exim 2.10 #35)
id 134p5W-00048e-00
for 36619-done@bugs.debian.org; Wed, 21 Jun 2000 19:18:58 +0100
Received: from jdg by polya with local (Exim 3.12 #1 (Debian))
id 134p5d-0001CC-00; Wed, 21 Jun 2000 19:19:05 +0100
Date: Wed, 21 Jun 2000 19:19:05 +0100
From: Julian Gilbey <J.D.Gilbey@qmw.ac.uk>
To: 36619-done@bugs.debian.org
Subject: Bug#36619: [REJECTED] Allowable values of PAGER variable should be described in policy
Message-ID: <20000621191905.A4593@polya>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
User-Agent: Mutt/1.0.1i
Delivered-To: 36619-done@bugs.debian.org
This proposal never received any support, so closing it.
Julian
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Julian Gilbey, Dept of Maths, QMW, Univ. of London. J.D.Gilbey@qmw.ac.uk
Debian GNU/Linux Developer, see http://www.debian.org/~jdg
Donate free food to the world's hungry: see http://www.thehungersite.com/
Reply to: