Bug#69487: marked as done (the example for using nostrip in DEB_BUILD_OPTIONS is incorrect)
Your message dated Mon, 28 Aug 2000 12:28:04 +0100
with message-id <20000828122804.A17862@polya>
and subject line Closed in debian-policy 3.2.1.0
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 20 Aug 2000 17:29:49 +0000
>From joy@cibalia.gkvk.hr Sun Aug 20 12:29:49 2000
Return-path: <joy@cibalia.gkvk.hr>
Received: from cibalia.gkvk.hr [::ffff:161.53.211.3]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 13QYum-0005Wq-00; Sun, 20 Aug 2000 12:29:46 -0500
Received: from joy by cibalia.gkvk.hr with local (Exim 2.05 #1 (Debian))
id 13QYwZ-0005TD-00; Sun, 20 Aug 2000 19:31:35 +0200
Date: Sun, 20 Aug 2000 19:31:35 +0200
From: Josip Rodin <joy@cibalia.gkvk.hr>
To: submit@bugs.debian.org
Subject: the example for using nostrip in DEB_BUILD_OPTIONS is incorrect
Message-ID: <[🔎] 20000820193135.A20986@cibalia.gkvk.hr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
User-Agent: Mutt/1.0pre2i
Delivered-To: submit@bugs.debian.org
Package: debian-policy
Version: 3.2.0.0
Hi,
Section `4.1 Binaries' says:
CFLAGS = -O2 -Wall
INSTALL = install
ifneq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
CFLAGS += -g
ifneq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
INSTALL += -s
endif
endif
The second ifneq needs to be ifeq.
Furthermore, I think this form would be a bit more readable:
ifneq "$(findstring debug,$(DEB_BUILD_OPTIONS))" ""
CFLAGS += -g
endif
ifeq "$(findstring nostrip,$(DEB_BUILD_OPTIONS))" ""
INSTALL += -s
endif
Or even:
ifeq "$(findstring debug,$(DEB_BUILD_OPTIONS))" "debug"
CFLAGS += -g
endif
ifneq "$(findstring nostrip,$(DEB_BUILD_OPTIONS))" "nostrip"
INSTALL += -s
endif
Or a combination :) Pick whichever people find nicest, as long as the logic
is correct.
--
Digital Electronic Being Intended for Assassination and Nullification
---------------------------------------
Received: (at 69487-done) by bugs.debian.org; 28 Aug 2000 11:28:27 +0000
>From J.D.Gilbey@qmw.ac.uk Mon Aug 28 06:28:27 2000
Return-path: <J.D.Gilbey@qmw.ac.uk>
Received: from mserv1a.vianw.co.uk [::ffff:195.102.240.34]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 13TN5W-0006tx-00; Mon, 28 Aug 2000 06:28:26 -0500
Received: from [195.102.196.197] (helo=polya)
by mserv1a.vianw.co.uk with esmtp (Exim 2.10 #63)
id 13TN5Q-0006Lf-00; Mon, 28 Aug 2000 12:28:21 +0100
Received: from jdg by polya with local (Exim 3.12 #1 (Debian))
id 13TN5A-0004eC-00; Mon, 28 Aug 2000 12:28:04 +0100
Date: Mon, 28 Aug 2000 12:28:04 +0100
From: Julian Gilbey <J.D.Gilbey@qmw.ac.uk>
To: 46522-done@bugs.debian.org, 48247-done@bugs.debian.org,
50832-done@bugs.debian.org, 53759-done@bugs.debian.org,
58759-done@bugs.debian.org, 61308-done@bugs.debian.org,
62668-done@bugs.debian.org, 62946-done@bugs.debian.org,
62947-done@bugs.debian.org, 62948-done@bugs.debian.org,
64004-done@bugs.debian.org, 64006-done@bugs.debian.org,
64437-done@bugs.debian.org, 64516-done@bugs.debian.org,
69031-done@bugs.debian.org, 69424-done@bugs.debian.org,
69426-done@bugs.debian.org, 69487-done@bugs.debian.org,
69670-done@bugs.debian.org
Cc: Manoj Srivastava <srivasta@debian.org>
Subject: Closed in debian-policy 3.2.1.0
Message-ID: <20000828122804.A17862@polya>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
User-Agent: Mutt/1.0.1i
Delivered-To: 69487-done@bugs.debian.org
Thanks to Manoj for closing all of these bugs in debian-policy version
3.2.1.0.
Julian
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Julian Gilbey, Dept of Maths, QMW, Univ. of London. J.D.Gilbey@qmw.ac.uk
Debian GNU/Linux Developer, see http://www.debian.org/~jdg
Donate free food to the world's hungry: see http://www.thehungersite.com/
Reply to: