[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#69487: the example for using nostrip in DEB_BUILD_OPTIONS is incorrect



> ifneq "$(findstring debug,$(DEB_BUILD_OPTIONS))" ""
>   CFLAGS += -g
> endif
> ifeq "$(findstring nostrip,$(DEB_BUILD_OPTIONS))" ""
>   INSTALL += -s
> endif

The nostrip check needs to be inside the debug check. Because of you are
not compiling with debugging turned on, there's no reason to not strip the
binaries. So (note, the blank should go first):

ifneq "" "$(findstring debug,$(DEB_BUILD_OPTIONS))"
  CFLAGS += -g
  ifeq "" "$(findstring nostrip,$(DEB_BUILD_OPTIONS))"
    INSTALL += -s
  endif
endif

Also, I think Joey is likely to add nostrip detection to dh_strip, which
means for packages that use that, they wont need to detect the nostrip
option.

Ben

-- 
 -----------=======-=-======-=========-----------=====------------=-=------
/  Ben Collins  --  ...on that fantastic voyage...  --  Debian GNU/Linux   \
`  bcollins@debian.org  --  bcollins@openldap.org  --  bcollins@linux.com  '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'



Reply to: