[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[branden: Re: Bug#24853 acknowledged by developer (I have a "doc" symlink (so what do I win? :-))]



----- Forwarded message from Branden Robinson <branden> -----

Message-ID: <19980724154554.A4681@purdue.edu>
Date: Fri, 24 Jul 1998 15:45:54 -0500
From: Branden Robinson <branden>
To: control@bugs.debian.org, "Mark W. Eichin" <eichin@kitten.gen.ma.us>
Subject: Re: Bug#24853 acknowledged by developer (I have a "doc" symlink (so what do I win? :-))
References: <19980723171216.H2056@purdue.edu> <E0yyqdK-0000jy-00@swat.thok.org> <handler.24853.D24853.90123194329528.notifdone@bugs.debian.org> <xe1g1fr83h7.fsf@paycheck.thok.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.91.2i
In-Reply-To: <xe1g1fr83h7.fsf@paycheck.thok.org>; from Mark W. Eichin on Fri, Jul 24, 1998 at 03:15:48PM -0400
Status: RO
Content-Length: 3604
Lines: 91

unmerge 24853
retitle 24853 xbase symlinks break if /usr/X11R6 on separate device
thanks

[policy folks, please read the bug logs for this one]

On Fri, Jul 24, 1998 at 03:15:48PM -0400, Mark W. Eichin wrote:
> 
> >> These bugs were fixed in xfree86 3.3.2.2-4.
> 
> You sure?
> 
> Preparing to replace xbase 3.3.2.2-3 (using x/xbase_3.3.2.2-4.deb) ...
> Unpacking replacement xbase ...
> Setting up xbase (3.3.2.2-4) ...
> WARNING: An error has been found in this installation of the xbase
> package.  The file /usr/X11R6/lib/X11/doc
> should exist and it does not.  Please file a bug report against the
> xbase package reporting this fact.  See
> /usr/doc/debian/bug-reporting.txt for information on filing bugs.
> 
> Please read /usr/doc/xbase/README.Debian to get the most out of X.
> 
> % ls -al /usr/X11R6/lib/X11/doc
> lrwxrwxrwx   1 root     root           16 Jul 24 09:40
> /usr/X11R6/lib/X11/doc -> ../../../doc/X11

I think your case is pathological, so to speak.  (That doesn't mean I
think *you* are :) ). The policy manual says symlinks within the same
top-level directory (in this case, /usr) should be relative, and absolute
across top-level directories (for instance, the many links out of various
places in /usr/X11R6/lib/X11 into /etc/X11).  Lintian checks for this
stuff and what I do is lintian clean.  For -4 I added some logic to the
xbase preinst that makes sure /usr/X11R6/lib/X11/doc isn't already a plain
directory, which obviously isn't the case for you.  So things look right in
one respect to the package, and if you didn't have /usr/X11R6 mounted from
a different device they'd work fine.

Here's what the preinst does with the file in question:

# ensure canocical location of X11 documentation
for docdir in /usr/doc/X11 /usr/X11R6/lib/X11/doc; do
  [ -L $docdir ] && rm $docdir
done
[ -d /usr/X11R6/lib/X11/doc -a ! -L /usr/X11R6/lib/X11/doc ] && rm -r \
 /usr/X11R6/lib/X11/doc
# the next line *SHOULD* be redundant, but...
ln -s ../../../doc/X11 /usr/X11R6/lib/X11/doc

And later the postinst does some checks:

# final sanity checks
for file in /usr/X11R6/lib/X11/twm/system.twmrc \
[...]
            /usr/X11R6/lib/X11/doc \
            /usr/doc/X11/README.Debian \
            /usr/lib/X11 \
            /usr/bin/X11; do
  if [ -e $file ]; then
    if [ ! -L $file ]; then
      $condecho
      echo "WARNING: An error has been found in this installation of the xbase"
      echo "package.  The file $file"
      echo "should be a symlink and it is not.  Please file a bug report"
      echo "against the xbase package reporting this fact.  See"
      echo "/usr/doc/debian/bug-reporting.txt for information on filing bugs."
      condecho=echo
    fi
  else
    $condecho
    echo "WARNING: An error has been found in this installation of the xbase"
    echo "package.  The file $file"
    echo "should exist and it does not.  Please file a bug report against the"
    echo "xbase package reporting this fact.  See"
    echo "/usr/doc/debian/bug-reporting.txt for information on filing bugs."
    condecho=echo
  fi
done

[ -e filename ] does not evaluate true if filename is a broken symlink, and
for my purposes that's desirable behavior.

I suppose this needs to be taken to the policy group.  Either we need to
support folks who have /usr/X11R6 mounted from a different device, or we
need to forbid it.  Either way something has to change.

-- 
G. Branden Robinson                 |
Purdue University                   |           //     // //  /     /
branden@purdue.edu                  |           EI 'AANIIGOO 'AHOOT'E
http://www.ecn.purdue.edu/~branden/ |

----- End forwarded message -----

-- 
G. Branden Robinson                 |  You can have my PGP passphrase when you
Purdue University                   |  pry it from my cold, dead brain.
branden@purdue.edu                  |  -- Adam Thornton
http://www.ecn.purdue.edu/~branden/ |

Attachment: pgpLDI9NwKz_s.pgp
Description: PGP signature


Reply to: