Re: bug #23953 ae: postinst does not check for errors
-----BEGIN PGP SIGNED MESSAGE-----
On Fri, 17 Jul 1998, Dale Scheetz wrote:
> On Fri, 17 Jul 1998, Herbert Xu wrote:
>
> > On Thu, Jul 16, 1998 at 07:54:26PM -0400, Dale Scheetz wrote:
> > >
> > > The function of these scripts is to conditionally install ae as "EDITOR"
> > > using alternatives. If this fails the rest of the ae install is not
> > > effected, and ae will be fully functional.
> >
> > Sure, so there is no problem setting -e then.
>
> If I set -e and update-alternatives fails then the script fails and the
> install fails. Without set -e if update-alternatives fails, the script
> does not, and the install succeeds.
But the point is that we want it to fail! That's why the policy is written
in the way it is written.
If update-alternatives fails, the install should *not* succeed.
I will quote policy:
Shell scripts (sh and bash) should almost certainly start with set -e
so that errors are detected. Every script must use set -e or check the
exit status of every command.
I think the policy is very clear here. Dale, I think you are interpreting
the policy in a very liberal way in this case.
-----BEGIN PGP SIGNATURE-----
Version: 2.6.3ia
Charset: latin1
iQCVAgUBNa+Y9SqK7IlOjMLFAQGpUwQAiLDEf0WrecDLOsBYygQ03BxGpQ1mCyWT
LdBbwWRaTF5+EE8Xlwed5eGNdLgGcayi6rXaoEPWPsEVphJNij+WSmj7L/zeKz6Y
skTB/V7eB+RHuKUECvqjwdltvhnpH2aVcRmdxJg73EQcN+H2t06XOqN2RFlym/WE
kR7pEvWcd30=
=Z2di
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to debian-policy-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Reply to: