On Tue, 07 Oct 2025 00:21:51 +1300, Andrew Ruthven wrote: Some rather quick review:
libwebservice-dropbox-perl https://salsa.debian.org/perl-team/modules/packages/libwebservice-dropbox-perl
* debian/libwebservice-dropbox-perl.docs can probably be removed (the files are in .examples anyway) * d/control: one of libmodule-build-perl and libmodule-build-tiny-perl should be enough (I suppose the -tiny variant) * I: libwebservice-dropbox-perl: wrong-section-according-to-package-name misc => perl
libalgorithm-loops-perl https://salsa.debian.org/perl-team/modules/packages/libalgorithm-loops-perl
* Maybe install ex/ as examples? * d/control: short description should be a noun phrase * I: libalgorithm-loops-perl source: patch-not-forwarded-upstream [debian/patches/fix-pod.patch]
libfuture-http-perl https://salsa.debian.org/perl-team/modules/packages/libfuture-http-perl
* d/control: short description should be a noun phrase * version contraints (libexperimental-perl libfuture-perl) seem to be satisfied in oldstable * Maybe add debian/tests/pkg-perl/syntax-skip
libmoox-role-eventemitter-perl https://salsa.debian.org/perl-team/modules/packages/libmoox-role-eventemitter-perl
* Hrm, this wohl copyright/license situation is a bit weird. In any case, LICENSE contains Artistic-2.0 * Short and long description are quite terse :) * ITP bug in d/changelog * autopkgtest smoke.t fails
libobject-import-perl https://salsa.debian.org/perl-team/modules/packages/libobject-import-perl
* d/copyright: that's unusual: "??, Max Maischein <corion@cpan.org>" :) and in general I only see Zsban Ambrus as a copyright holder * d/control: no "<!nocheck>" for libmath-bigint-perl?
libnet-async-websocket-perl https://salsa.debian.org/perl-team/modules/packages/libnet-async-websocket-perl
* libtest-simple-perl | libtest2-suite-perl --> 2x "<!nocheck>" and probably "libtest-simple-perl (>= 1.302200) <!nocheck> | libtest2-suite-perl <!nocheck>" * d/control: short description should be a noun phrase
libwww-mechanize-chrome-perl https://salsa.debian.org/perl-team/modules/packages/libwww-mechanize-chrome-perl This one isn't ready for upload yet, there are two failing tests. I've created tickets upstream for them. However, the package can still be reviewed.
* debian/libwww-mechanize-chrome-perl.docs -> can be removed, contains examples * demo/ -> install as examples? and, as these are binary files, the usual questions: preferred form for modfication, copright/license? Ok, I watched one, looks like a harmless screen recording by upstream :) * libfuture-http-perl (>= 0.06) --> no version constraint needed * d/control: description: typo: WWW::Mechianize::Chrome * libexperimental-perl (>= 0.031) -> satisfied in oldstable (I didn't build this one)
libselenium-remote-driver-perl https://salsa.debian.org/perl-team/modules/packages/libselenium-remote-driver-perl
* 1.50 is available upstreams :) * debian/patches/fix-env-path.patch: I'd use "#!/usr/bin/perl" and I'd do the fixup in d/rules instead of a patch, cf. https://perl-team.pages.debian.net/debhelper.html#Fixing_Interpreter_Shebang_Lines and many packages * git mv debian/lintian-overrides debian/libselenium-remote-driver-perl.llintian-overrides (I think future debhelper will enforce the <pkg>.something variant) * d/copyright: (not checked now) * The package installs ./usr/share/perl5/Selenium/Remote/driver-example.pl Is this a good/the right place? * lib/Selenium/Firefox/webdriver.xpi sounds interesting :) And looking into it is even more interesting, e.g. there's a Windows .dll in it … Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe`-
Attachment:
signature.asc
Description: Digital Signature