[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Undefined subroutine errors (spider-bts) Was: [Debian-l10n-devel] [Help] Re: dl10n-check: Can't locate Debian/Pkg/DebSrc.pm in @INC

Hi all,

Unfortunately it was me that broke it in commit a985438ed248ff54383a9998bd7fd6293c628584 - https://salsa.debian.org/l10n-team/dl10n/-/merge_requests/10 fixes it.
Explanation: I added the =encoding line, and didn't notice that in Html.pm (unlike the other two .pm files) there was substantive code (a package statement) instead of immediately a POD statement (=head1). I have fixed this more long-term by moving that package statement to below all the POD, as in the other two.

You can check this locally by doing perl -Ilib dl10n-html with/without the change: without, you'll see the error Laura reported, with, you'll see it gets further, saying it can't find data.

Best regards,
Ed

From: Laura Arjona Reina <larjona@debian.org>
Sent: 19 November 2024 2:38 PM
To: Holger Wansing <hwansing@mailbox.org>; Andreas Tille <tille@debian.org>; Damyan Ivanov <dmn@debian.org>; debian-perl@lists.debian.org <debian-perl@lists.debian.org>; Package Salvaging Team <team+salvage@tracker.debian.org>; 805378@bugs.debian.org <805378@bugs.debian.org>; Debian l10n development team <debian-l10n-devel@lists.alioth.debian.org>
Subject: Re: Undefined subroutine errors (spider-bts) Was: [Debian-l10n-devel] [Help] Re: dl10n-check: Can't locate Debian/Pkg/DebSrc.pm in @INC
 

Hello

Thanks for the quick answer.

El 19/11/24 a las 15:16, gregor herrmann escribió:
On Tue, 19 Nov 2024 15:01:27 +0100, Laura Arjona Reina wrote:


Looking at the log, it says:

Undefined subroutine &Html::html called at
/srv/i18n.debian.org//dl10n/git/dl10n-html line 140.

We have the file in dl10n/git/lib/Debian/L10n/Html.pm that includes the
subroutine hmtl() and it was working without issues. I think that now Perl
in tye.d.o cannot find it but I don't know why, because the cron job (script https://salsa.debian.org/l10n-team/dl10n/-/blob/master/cron/spiderbts?ref_type=heads
) gets the configuration from file dl10n.conf as the other scripts.

Was perl upgraded?
No AFAIK, we have 11.11 in tye, and perl 5.32.1-4+deb11u4 


Anyway, looks indeed like
./dl10n-html
doesn't find
./lib

<guess>
I'd try to add
    use lib '.';
at the top of dl10n-html, e.g. after "use POSIX qw(strftime);"
in https://salsa.debian.org/l10n-team/dl10n/-/blob/master/dl10n-html?ref_type=heads#L32

I tried this (manually editing the file in tye.debian.org) and got the same error, also tried to write the line more on top, in L5, with no changes.

or call dl10n-html from the cronjob as "perl -I<full path to the
lib/directory>, e.g.
    PERL -I$DL10NDIR/lib $DL10NDIR/dl10n-html --sdb …
in https://salsa.debian.org/l10n-team/dl10n/-/blob/master/cron/spiderbts?ref_type=heads#L46
</guess>

I also tried this, editing the spiderbts file in tye.debian.org (used "perl" instead of PERL) obtaining the same error:

Undefined subroutine &Debian::L10n::Html::html called at /srv/i18n.debian.org//dl10n/git/dl10n-html line 140.

(I also changed the message written in the .log file to be sure that the system was running my modified script).

Kind regards,

-- 
Laura Arjona Reina
https://wiki.debian.org/LauraArjona
Reply to: